Apply formatter selected in initialization options #1886
Merged
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
bugfix
andyw8
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #1884
The global state refactor introduced a regression. We were eagerly detecting the formatter and then never taking into consideration initialization options coming from editors, which makes it impossible to use our
rubyLsp.formatteroption to select which formatter you want to use.Implementation
We can't detect the formatter eagerly, that can only happen if the formatter is set to
autoafter we already applied the user's configurations.So we initialize it to
auto, override it if something is coming from configurations and then only detect the formatter if after all that it is still set toauto.Automated Tests
Added a couple of new tests.